Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run compliance checks on Zuul (resolves #316) #362

Merged
merged 47 commits into from
Nov 30, 2023
Merged

Run compliance checks on Zuul (resolves #316) #362

merged 47 commits into from
Nov 30, 2023

Conversation

mbuechse
Copy link
Contributor

No description provided.

@fkr
Copy link
Member

fkr commented Oct 20, 2023

wow. cool!

@mbuechse mbuechse linked an issue Oct 26, 2023 that may be closed by this pull request
Run tests for SCS-compatible IaaS via Zuul #316
Closed
@mbuechse
Copy link
Contributor Author

mbuechse commented Nov 10, 2023 •
edited
Loading

gx-scs-iaas.yaml.txt

"live" version

Extended YAML file:

  • all valid and upcoming versions are tested
  • each check tool is only run once for each argument
  • contains rc, stderr, stdout, and number of lines starting with info, warning, error, and critical

@mbuechse mbuechse marked this pull request as ready for review November 16, 2023 10:26
chess-knight
chess-knight reviewed Nov 20, 2023
View reviewed changes
.zuul.d/config.yaml Outdated Show resolved Hide resolved
@fkr fkr requested a review from chess-knight November 29, 2023 09:27
berendt
berendt requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@berendt berendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits...

.zuul.d/secure.yaml Outdated Show resolved Hide resolved
Tests/iaas/flavor-naming/flavor-names-openstack.py Show resolved Hide resolved
Tests/iaas/image-metadata/image-md-check.py Show resolved Hide resolved
playbooks/clouds.yaml.j2 Show resolved Hide resolved
playbooks/compliance_check.yaml Outdated Show resolved Hide resolved
@mbuechse
Copy link
Contributor Author

@berendt I think I addressed your remarks. And the job still works: https://zuul.scs.community/t/SCS/builds?job_name=scs-check-gx-scs

@mbuechse mbuechse requested a review from berendt November 29, 2023 11:33
@mbuechse
Initial attempt at getting the compliance check to run via zuul
7085207 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
restructured to have secrets in a separate file
ce3330b 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Simplify structure, pacify ansible-lint
8ac8ca4 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Make sure pip is available
d299bc9 
(as seen here: https://github.com/SovereignCloudStack/k8s-cluster-api-provider/blob/main/playbooks/dependencies.yaml)

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Bugfix: secret name must be unique
829ebd6 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Bugfix: fix relative path after 88b9fe3
32ca527 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Bugfix: fixed parsing of args and determining of search path
10429f3 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
In spite of the fix in 040bc8e, use workaround when calling the check…
95bd73f 
… tool

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Allow restricting check tools according to resource classification
87aa2f3 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Master check tool doesn't fiddle with the environment
25eb291 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Reverse order in scs-compatible-iaas.yaml, add new, still-unstable ve…
6b8fd3b 
…rsion (will be skipped anyway)

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Check all valid and upcoming versions if no version is forced
b1fac89 
But don't run any combination of executable/args multiple times

Signed-off-by: Matthias Büchse <[email protected]>
mbuechse and others added 22 commits November 30, 2023 12:38
@mbuechse
Reincorporate debug output
a5eaddf 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Debug: remove -q
a45acc6 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Bugfix: SystemExit is not critical
eb9badf 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Add task to copy artifact back
b1e8f10 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Added more cloud environments
9e29bba 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Bugfix: missing auth_type
4d5bfc1 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Copying didn't work; try synchronize
5949228 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Fix typo
2ba3fde 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Move compliance checks to daily, except for gx-scs for further debugging
c759d26 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Improved report format
fb48cc7 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Yet another slight improvement of the report format
19b3691 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Make number of ERROR lines match return code
5ee1ee9 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Remove comment
c1145d5 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Refactoring: improve check_keywords
aadd99f 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Bugfix and documentation around run_check_tool in case of http url
105ce0d 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Add Regiocloud RegionA
9e720e6 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse @chess-knight
Fix missing quote marks, thanks @chess-knight for spotting
778c8fc 
Co-authored-by: Roman Hros <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Changed pipeline because post-review: true is needed
198e2d5 
Thanks @chess-knight!

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Comply with secret naming convention, use document start marker; thanks
31fa7cd 
@berendt

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Add even more document start markers
55d97a4 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Fix changed_when, thanks @berendt
b07d33e 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Address ansible-lint recommendations
19cb0bc 
Signed-off-by: Matthias Büchse <[email protected]>
berendt
berendt approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@berendt berendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Because of the huge amount of small commits I think it makses sense to do a squash merge.

chess-knight
chess-knight approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mbuechse mbuechse merged commit 8dc1b9b into main Nov 30, 2023
3 checks passed
@mbuechse mbuechse deleted the issue/316 branch November 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chess-knight chess-knight chess-knight approved these changes

@berendt berendt berendt approved these changes

@garloff garloff Awaiting requested review from garloff

@fkr fkr Awaiting requested review from fkr

@fdobrovolny fdobrovolny Awaiting requested review from fdobrovolny

Assignees

@mbuechse mbuechse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests for SCS-compatible IaaS via Zuul
4 participants
@mbuechse @fkr @berendt @chess-knight