Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft 'Implementation and Testing notes' supplementary documents for select standards #443

Merged
merged 17 commits into from
Mar 8, 2024
Merged

Draft 'Implementation and Testing notes' supplementary documents for select standards #443

merged 17 commits into from
Mar 8, 2024

Conversation

mbuechse
Copy link
Contributor

@mbuechse mbuechse commented Jan 9, 2024

Resolves #437

@mbuechse mbuechse requested a review from garloff January 9, 2024 11:22
@mbuechse mbuechse marked this pull request as ready for review January 9, 2024 16:21
@anjastrunk anjastrunk self-requested a review January 17, 2024 12:17
fdobrovolny
fdobrovolny approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@fdobrovolny fdobrovolny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM added a few points for improvement, but overall, it is nice.

Standards/scs-0100-w1-flavor-naming-implementation-testing.md Outdated Show resolved Hide resolved
Standards/scs-0101-w1-entropy-implementation-testing.md Show resolved Hide resolved
Standards/scs-0101-w1-entropy-implementation-testing.md Outdated Show resolved Hide resolved
@mbuechse mbuechse mentioned this pull request Jan 19, 2024
Closed
cah-hbaum
cah-hbaum approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@cah-hbaum cah-hbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

artificial-intelligence
artificial-intelligence reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just two small notes.

Standards/scs-0100-w1-flavor-naming-implementation-testing.md Show resolved Hide resolved
Standards/scs-0100-v3-flavor-naming.md Show resolved Hide resolved
anjastrunk
anjastrunk approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@anjastrunk anjastrunk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

artificial-intelligence
artificial-intelligence approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbuechse
Copy link
Contributor Author

mbuechse commented Mar 4, 2024 •
edited
Loading

@maxwolfs I surrender! If I use a relative path in the Markdown file, Markdownlint will fail. If I use an absolute path (one that is indeed working within Github), then the link check will fail. What???

@maxwolfs
Copy link
Member

maxwolfs commented Mar 4, 2024 •
edited
Loading

@maxwolfs I surrender! If I use a relative path in the Markdown file, Markdownlint will fail. If I use an absolute path (one that is indeed working within Github), then the link check will fail. What???

The logs of the failed link check only fails on relative links as far as i can see:

ERROR: 3 dead links found!
  [✖] /Tests/iaas/flavor-naming → Status: 400
  [✖] /Tests/iaas/flavor-naming/cli.py → Status: 400
  [✖] /Tests/iaas/flavor-naming/README.md → Status: 400

mbuechse added 14 commits March 8, 2024 10:11
@mbuechse
Initial attempt of a supplemental document regarding implementation a…
cea98ae 
…nd testing of scs-0100-v3

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Syntax error in front matter
d315d6f 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
minor improvements
8856063 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Adapt ADR check script
c932086 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Add supplement to entropy standard
f77f36a 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Correction: mention that attributes have to be set
98407e9 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Bugfix: subsection on manual tests was two levels too deep
c457c45 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Minor improvements
03c0209 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Relax testing notes to accommodate previous commit
90fd475 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Update docstring of entropy-check.py
94ee07f 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
State examples for flavor properties that are not immediately discove…
e721eb7 
…rable

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Extend scs-0001 in regard to Supplement type
09c0569 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Update the section on Operation Tooling
6276721 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Use relative URIs
3e96fff 
Signed-off-by: Matthias Büchse <[email protected]>
garloff
garloff requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me commit those two spell fixes before I approve ...

Standards/scs-0100-w1-flavor-naming-implementation-testing.md Outdated Show resolved Hide resolved
Standards/scs-0100-w1-flavor-naming-implementation-testing.md Outdated Show resolved Hide resolved
garloff
garloff approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, thanks, @mbuechse!

@mbuechse mbuechse merged commit 3a3c524 into main Mar 8, 2024
4 checks passed
@mbuechse mbuechse deleted the issue/437 branch March 8, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkr fkr fkr left review comments

@maxwolfs maxwolfs maxwolfs left review comments

@anjastrunk anjastrunk anjastrunk approved these changes

@fdobrovolny fdobrovolny fdobrovolny approved these changes

@artificial-intelligence artificial-intelligence artificial-intelligence approved these changes

@garloff garloff garloff approved these changes

@cah-hbaum cah-hbaum cah-hbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draft 'Implementation and Testing notes' supplementary documents for select standards
8 participants
@mbuechse @maxwolfs @fkr @fdobrovolny @artificial-intelligence @garloff @cah-hbaum @anjastrunk