Alternative proposal for a volume type standard #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbuechse
force-pushed
the
volume-type-standard-proposal
branch
from
680ef59 to
3398cb9
Compare
Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
mbuechse
force-pushed
the
volume-type-standard-proposal
branch
from
3398cb9 to
d5034b2
Compare
anjastrunk
reviewed
Feb 27, 2024
| As an SCS user, I want to be able to create volumes with certain common features, such as encryption or | ||
| replication, and to do so in a standardized manner as well as programmatically. | ||
| This standard outlines a way of formally advertising these common features for a volume type to | ||
| non-privileged users, so that the most suitable volume type can be discovered and selected easily--both by |
There was a problem hiding this comment.
Missing white spaces?
Suggested change
| non-privileged users, so that the most suitable volume type can be discovered and selected easily--both by | |
| non-privileged users, so that the most suitable volume type can be discovered and selected easily -- both by |
anjastrunk
reviewed
Feb 27, 2024
anjastrunk
reviewed
Feb 27, 2024
| The features of a volume type MAY be advertised by putting a _feature list_ in front of its description. | ||
| A feature list has the following form: | ||
|
|
||
| `[feat:`feat1,feat2,...,featN`]` |
There was a problem hiding this comment.
To separate from other approaches, I prefer an scs specific prefix, such as scs-feat.
anjastrunk
reviewed
Feb 27, 2024
| ## Recommended volume types | ||
|
|
||
| At least one volume type SHOULD feature encryption. | ||
|
|
There was a problem hiding this comment.
I prefer to add an example, as in previous approach #351:
openstack volume type show LUKS
+--------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+--------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
| access_project_ids | None |
| description | [scs:encrypted] This volume uses LUKS-encryption |
| id | d63307fb-167a-4aa0-9066-66595ea9fb21 |
| is_public | True |
| name | LUKS |
| qos_specs_id | None |
+--------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
anjastrunk
reviewed
Feb 27, 2024
|
|
||
| where the entries (feat1, ..., featN) are sorted alphabetically, and each entry occurs at most once. | ||
|
|
||
| ## Recommended volume types |
There was a problem hiding this comment.
Should we specify mandartory or recommenced properties of encryption, such as cipher and key size?
anjastrunk
reviewed
Feb 27, 2024
|
|
||
| At least one volume type SHOULD feature encryption. | ||
|
|
||
| At least one volume type SHOULD feature replicaton. |
There was a problem hiding this comment.
I prefer to add define requirements or recommendations for replication. I.e. how replication ins achieved and how many replicas exists.
anjastrunk
reviewed
Feb 27, 2024
| At least one volume type SHOULD feature encryption. | ||
|
|
||
| At least one volume type SHOULD feature replicaton. | ||
|
|
There was a problem hiding this comment.
I suggest to add an example, like in #351
+--------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+--------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
| access_project_ids | None |
| description | [scs:encrypted][scs:replicated] Content will be replicated three times to ensure consistency and availability for your data. LUKS encryption is used. |
| id | d63307fb-167a-4aa0-9066-66595ea9fb21 |
| is_public | True |
| name | hdd-three-replicas-LUKS |
| properties | |
| qos_specs_id | None |
+--------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
anjastrunk
requested changes
Feb 27, 2024
|
I was wondering: Since @anjastrunk now reviewed this PR, and #351 is still open and thus far there was no further discussion (as far as I know (and nothing in the minutes of Sig Std) I wondered wether this has been discussed between @josephineSei, @mbuechse and @anjastrunk as I suggested. |
Merged
mbuechse
commented
Mar 6, 2024
Co-authored-by: Matthias Büchse <[email protected]> Signed-off-by: anjastrunk <[email protected]>
|
can this PR be closed since the other volume type standards PR got basically finalized? |
|
this has been dealt with in #351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #265
This is meant to illustrate what I have in mind. I did not include the optional features, but I think it's easy to see how they would fit in.