Expand status-page-openapi-spec-decision with severity levels #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snkaupe
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Text needs a bit of work due to some typos and the illustration of how a severity's range is calculated being a bit unclear, but the content is good, with the possible exception of using the severity names as unique identifiers. I'd suggest using a different type of identifier, such as the UUIDs we use everywhere else.
joshmue
reviewed
Mar 6, 2024
joshmue
reviewed
Mar 6, 2024
joshuai96
commented
Mar 6, 2024
Signed-off-by: Joshua Irmer <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
joshuai96
force-pushed
the
status-page-openapi-spec-update
branch
from
41e9bef to
147835f
Compare
joshmue
approved these changes
Mar 21, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacts might have different severities on a systems component. For the further development of the
status-page-webproject, these severities must be defined on the API service.