-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the Domain Manager role to "manager" #523
Conversation
Need to test the changed test script implementation but need a suitable test Keystone instance first. Marking as draft for now. |
Signed-off-by: Markus Hentsch <[email protected]>
5227459
to
aaed69f
Compare
I've now successfully verified that it works the same using the Before removing the draft state I need to also create a corresponding PR for the docs at https://docs.scs.community/docs/iam/domain-manager-setup-and-usage/ |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few places, that are still mentioning the role.
It would be good to add a definition of role and persona in the beginning or the glossary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This implements our decision to rename the role1 to follow the request by upstream2.
Footnotes
https://github.com/SovereignCloudStack/minutes/blob/main/iaas/20240313.md#domain-manager-rolepersona-markus-hentsch ↩
https://review.opendev.org/c/openstack/keystone-specs/+/903172/2/specs/keystone/2023.1/domain-manager-role.rst#20 ↩