Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the Domain Manager role to "manager" #523

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

markus-hentsch
Copy link
Contributor

@markus-hentsch
Copy link
Contributor Author

Need to test the changed test script implementation but need a suitable test Keystone instance first.

Marking as draft for now.

@markus-hentsch markus-hentsch force-pushed the fix/rename-domain-manager-role branch from 5227459 to aaed69f Compare March 15, 2024 17:19
@markus-hentsch
Copy link
Contributor Author

Need to test the changed test script implementation but need a suitable test Keystone instance first.

I've now successfully verified that it works the same using the manager role and the tests still pass.
Verified using a minimal DevStack I built up as documented here: https://gist.github.com/markus-hentsch/b0f7315a9ad6f5dc8621727056df275e

Before removing the draft state I need to also create a corresponding PR for the docs at https://docs.scs.community/docs/iam/domain-manager-setup-and-usage/

@markus-hentsch
Copy link
Contributor Author

Before removing the draft state I need to also create a corresponding PR for the docs at https://docs.scs.community/docs/iam/domain-manager-setup-and-usage/

Done: SovereignCloudStack/docs#163

@markus-hentsch markus-hentsch marked this pull request as ready for review March 18, 2024 09:43
Copy link
Contributor

@josephineSei josephineSei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few places, that are still mentioning the role.
It would be good to add a definition of role and persona in the beginning or the glossary.

Copy link
Contributor

@josephineSei josephineSei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markus-hentsch markus-hentsch merged commit 73e9242 into main Mar 21, 2024
5 checks passed
@markus-hentsch markus-hentsch deleted the fix/rename-domain-manager-role branch March 21, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SCS-VP10 Related to tender lot SCS-VP10
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants