Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs regarding used variable for kubeconfig #838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix docs regarding used variable for kubeconfig #838

wants to merge 1 commit into from

Conversation

sluetze
Copy link
Contributor

@sluetze sluetze commented Nov 21, 2024

fixing #837

@mbuechse mbuechse linked an issue Nov 22, 2024 that may be closed by this pull request
[BUG] subject_root variable missing #837
Open
mbuechse
mbuechse reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! I'm afraid this state of affairs is far from optimal. We should try to revert back to the old variable (as it's documented).

@garloff garloff mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbuechse mbuechse mbuechse left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] subject_root variable missing
2 participants
@sluetze @mbuechse