Adjust PCO SCS IaaS-compatible checks. #867
Merged
+26
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
garloff
commented
Jan 10, 2025
garloff
commented
- Using AppCreds for Prod1 and Prod2 (was using usernm, passwd before)
- Name Secrets OS_ACSECRET_PCOPROD[1-4] rather than OS_PASSWORD_...
- Run v4 checks 5mins past v3 checks.
- Using AppCreds for Prod1 and Prod2 (was using usernm, passwd before) - Name Secrets OS_ACSECRET_PCOPROD[1-4] rather than OS_PASSWORD_... - Run v4 checks 5mins past v3 checks. Signed-off-by: Kurt Garloff <[email protected]>
mbuechse
approved these changes
Jan 10, 2025
berendt
requested changes
Jan 10, 2025
… not the setting in one case... Thanks for the fix! Co-authored-by: Matthias Büchse <[email protected]> Signed-off-by: Kurt Garloff <[email protected]>
berendt
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.