Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fjern massa onødvendig javascript fra Collapse #1872

Merged
merged 4 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useState } from 'react';
import { InlineExpandButton } from '@sb1/ffe-buttons-react';
import Collapse from '@sb1/ffe-collapse-react';
import { Collapse } from '@sb1/ffe-collapse-react';
import { Paragraph } from '@sb1/ffe-core-react';

() => {
Expand Down
2 changes: 1 addition & 1 deletion component-overview/examples/collapse/Collapse-onRest.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useState } from 'react';
import Collapse from '@sb1/ffe-collapse-react';
import { Collapse } from '@sb1/ffe-collapse-react';
import { ExpandButton } from '@sb1/ffe-buttons-react';

() => {
Expand Down
2 changes: 1 addition & 1 deletion component-overview/examples/collapse/Collapse.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useState } from 'react';
import Collapse from '@sb1/ffe-collapse-react';
import { Collapse } from '@sb1/ffe-collapse-react';
import { ExpandButton } from '@sb1/ffe-buttons-react';

() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/ffe-accordion-react/src/AccordionItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useEffect, useRef, useState } from 'react';
import { bool, func, node, string } from 'prop-types';
import { v4 as uuid } from 'uuid';
import { Icon } from '@sb1/ffe-icons-react';
import Collapse from '@sb1/ffe-collapse-react';
import { Collapse } from '@sb1/ffe-collapse-react';
import classNames from 'classnames';

const AccordionItem = ({
Expand Down
19 changes: 17 additions & 2 deletions packages/ffe-collapse-react/less/collapse.less
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
.ffe-collapse-transition {
transition: height @ffe-transition-duration @ffe-ease;
.ffe-collapse {
display: grid;
grid-template-rows: 0fr;
transition: grid-template-rows var(--ffe-transition-duration)
var(--ffe-ease);
}

.ffe-collapse--hidden {
visibility: hidden;
}

.ffe-collapse--open {
grid-template-rows: 1fr;
}

.ffe-collapse__inner {
overflow: hidden;
}
109 changes: 40 additions & 69 deletions packages/ffe-collapse-react/src/Collapse.js
Original file line number Diff line number Diff line change
@@ -1,82 +1,53 @@
import React, { useRef, useState, useEffect } from 'react';
import { string, bool, func, object } from 'prop-types';
import React, { useRef, useEffect, useState } from 'react';
import { string, bool, func, node } from 'prop-types';
import classNames from 'classnames';

const Collapse = ({ className, style, isOpen, onRest, ...rest }) => {
const content = useRef();
const [height, setHeight] = useState(() => (isOpen ? 'auto' : '0'));
const [overflow, setOverflow] = useState(() =>
isOpen ? 'visible' : 'hidden',
);
const [visibility, setVisibility] = useState(() =>
isOpen ? 'visible' : 'hidden',
Copy link
Contributor

@frederikgdl frederikgdl Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde kanskje beholde visibility hidden når den er lukket? Da kan ikke elementer fokuseres når den er lukket. Ser det ikke er et problem for accordion for der rendres ikke innholdet hvis lukket

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det er ett veldig gott poeng. Det skall jag få fikset

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

);
export const Collapse = React.forwardRef(
({ className, isOpen, onRest, children, ...rest }, ref) => {
const internalRef = useRef();
const collapse = ref ?? internalRef;
const [isHidden, setIsHidden] = useState(!isOpen);

const setExpanded = () => {
setHeight('auto');
setOverflow('visible');
};

const setCollapsed = () => {
setVisibility('hidden');
};

useEffect(() => {
if (content.current) {
if (isOpen && height !== 'auto') {
setHeight(`${content.current.scrollHeight}px`);
setVisibility('visible');
} else if (!isOpen && height !== '0') {
setHeight(`${content.current.scrollHeight}px`);
window.requestAnimationFrame(() =>
setTimeout(() => {
setHeight('0');
setOverflow('hidden');
}),
);
}
}
}, [isOpen, height]);

const onTransitionEnd = e => {
if (e.target === content.current && e.propertyName === 'height') {
useEffect(() => {
if (isOpen) {
setExpanded();
} else {
setCollapsed();
}
if (onRest) {
onRest();
setIsHidden(false);
}
}
};

const mergedStyles = {
...style,
willChange: 'height',
height,
overflow,
visibility,
};

return (
<div
{...rest}
ref={content}
style={mergedStyles}
className={classNames('ffe-collapse-transition', className)}
onTransitionEnd={onTransitionEnd}
/>
);
};
}, [isOpen]);

return (
<div
{...rest}
ref={collapse}
className={classNames('ffe-collapse', className, {
'ffe-collapse--open': isOpen,
'ffe-collapse--hidden': isHidden,
})}
onTransitionEnd={e => {
if (
e.target === collapse.current &&
e.propertyName === 'grid-template-rows'
) {
if (onRest) {
onRest();
}
if (!isOpen) {
setIsHidden(true);
}
}
}}
>
<div className="ffe-collapse__inner">{children}</div>
</div>
);
},
);

Collapse.displayName = 'Collapse';

Collapse.propTypes = {
className: string,
style: object,
isOpen: bool,
onRest: func,
/** The content to appear when expanded */
children: node.isRequired,
};

export default Collapse;
4 changes: 2 additions & 2 deletions packages/ffe-collapse-react/src/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import * as React from 'react';

export interface CollapseProps extends React.HTMLProps<HTMLDivElement> {
export interface CollapseProps extends React.ComponentProps<'div'> {
isOpen: boolean;
onRest?: () => void;
}

declare class Collapse extends React.Component<CollapseProps, any> {}

export default Collapse;
export { Collapse };
2 changes: 1 addition & 1 deletion packages/ffe-collapse-react/src/index.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default } from './Collapse';
export { Collapse } from './Collapse';
2 changes: 1 addition & 1 deletion packages/ffe-form-react/src/Tooltip.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { useState, useRef } from 'react';
import { bool, func, node, string, number } from 'prop-types';
import classNames from 'classnames';
import Collapse from '@sb1/ffe-collapse-react';
import { Collapse } from '@sb1/ffe-collapse-react';
import { v4 as uuid } from 'uuid';

const Tooltip = React.forwardRef(
Expand Down
Loading