Develop fix inputgroup text zoom #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1878.westeurope.2.azurestaticapps.net |
HeleneKassandra
approved these changes
Apr 16, 2024
added 2 commits
April 16, 2024 13:59
pethel
force-pushed
the
develop_fix-inputgroup-text-zoom
branch
from
bcb3570 to
9de7d45
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1878.westeurope.2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provar løsa fonskaleringproplematik på feilmeldninger. Dette er ett problem i alla inputgrupper, inklusive feedback #1835. Problemet er att dagen løsning lager padding under og feilmeldningen blir i prinsip absolut positionert der. Drar man upp fonten så ær paddingen. Det går nok ikke att bruke rem på paddingen under før vad hvis meldninen brekker på flere linjer.
Det jag gjort istellet er att laga en wrapper med minhøjde som er lika høy som en rad av texten. Dette er ingen perfekt løsning hvis man har zoom og høja meldninger så vill ting flytta seg men trot allt vare fullt synlig.
Jag tror dock dette funker bra før det man i utgangspunktet provade løsa. Korta meldniner som holder seg på en linje?
Hvis dere tester med firefox så funker det muligens ikke trots att nyare versioner skal l funka. Det er egentligen veldig bra support og dette er trots all en progressive enhancement.
Måtte endre markup. Breaking change?
https://caniuse.com/mdn-css_types_length_lh
