Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ffe-cards-react): rewrite in ts #1969

Merged
merged 2 commits into from
May 7, 2024
Merged

feat(ffe-cards-react): rewrite in ts #1969

merged 2 commits into from
May 7, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented May 6, 2024

Skrevet om til ts

@pethel pethel requested a review from a team as a code owner May 6, 2024 08:08
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_cards-as-ts branch from 8b62dcc to f13e402 Compare May 6, 2024 08:19
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_cards-as-ts branch from f13e402 to 1b00472 Compare May 6, 2024 18:00
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_cards-as-ts branch from 1b00472 to 8d9e7d4 Compare May 6, 2024 20:42
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_cards-as-ts branch from 741afc1 to 8318851 Compare May 7, 2024 08:38
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

antidecaf
antidecaf previously approved these changes May 7, 2024
View reviewed changes
@pethel pethel force-pushed the develop_cards-as-ts branch 2 times, most recently from 4c6348d to 830111f Compare May 7, 2024 09:18
@pethel pethel requested a review from antidecaf May 7, 2024 09:19
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

HeleneKassandra
HeleneKassandra previously approved these changes May 7, 2024
View reviewed changes
feat(ffe-cards-react): rewrite in ts
9355e77 
element -> as

BREAKING CHANGE: different props
@pethel pethel force-pushed the develop_cards-as-ts branch from 830111f to 5830a1c Compare May 7, 2024 09:47
@pethel pethel requested a review from HeleneKassandra May 7, 2024 09:47
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_cards-as-ts branch 2 times, most recently from 0130940 to 22216ac Compare May 7, 2024 10:11
@pethel pethel force-pushed the develop_cards-as-ts branch from 22216ac to 9b0cb6e Compare May 7, 2024 10:13
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1969.westeurope.2.azurestaticapps.net

@pethel pethel merged commit 7f6502d into develop May 7, 2024
3 checks passed
@pethel pethel deleted the develop_cards-as-ts branch May 7, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antidecaf antidecaf Awaiting requested review from antidecaf

@HeleneKassandra HeleneKassandra Awaiting requested review from HeleneKassandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pethel @antidecaf @HeleneKassandra