Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ffe-icons): Endre ikonstørrelse på lg og xl, (lg 40px -> 32px, xl 48px til 40px) #2473

Closed
wants to merge 1 commit into from

Conversation

hagenek
Copy link
Contributor

@hagenek hagenek commented Jan 14, 2025

Breaking change: Ikon med størrelse XL er nå blitt litt mindre (48px til 40px) og lg har blitt mindre (40px -> 32px).

@hagenek hagenek requested a review from a team as a code owner January 14, 2025 11:30
@hagenek hagenek force-pushed the change-sizes-icons branch from f28832a to f145aeb Compare January 14, 2025 11:31
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

@hagenek hagenek force-pushed the change-sizes-icons branch from f145aeb to 89f12d4 Compare January 14, 2025 11:42
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

@hagenek hagenek force-pushed the change-sizes-icons branch 3 times, most recently from 2cca4c4 to fa29633 Compare January 14, 2025 11:56
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

2 similar comments
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

@hagenek hagenek force-pushed the change-sizes-icons branch from fa29633 to 49fd60f Compare January 14, 2025 12:02
@HeleneKassandra
Copy link
Contributor

Dette blir ikke egentlig en breaking change sånn for brukerne med engang. Det er resultatet av byggscriptet som vil være den breaking changen. Og siden det byggscriptet sjekker om fila eksisterer kan det hende build.js ikke skjønner at den skal hente ned filene på nytt, så du må muligens inn å slette alle ikonene på størrelsene du har endret også kjøre build scriptet.

@hagenek hagenek force-pushed the change-sizes-icons branch from 49fd60f to b6d9df6 Compare January 14, 2025 12:03
@tuva-odegard
Copy link
Contributor

@HeleneKassandra Vi har oppdaget at 32px ikke finnes tilgjengelig sånn som det er gjort nå.. Så vi må finne andre måter å gjøre det på, senere tror vi..

@hagenek hagenek closed this Jan 14, 2025
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2473.westeurope.2.azurestaticapps.net

@hagenek hagenek deleted the change-sizes-icons branch January 14, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants