Nye størrelser på ikoner, lg går fra 40px til 32px og xl går fra 48 til 40

[hagenek]

BREAKING CHANGE: The lg size of icons is now 32px, and the xl size is 40px (was 48px).

Denne PR-en har også forandringer i scriptet som henter ikoner. Nå henter vi bare 40px versjonen av ikonene, også gjør vi resizingen osv. selv.

Siden vi ikke hadde hentet nye ikoner på over et år siden workflowen var ødelagt, er det endel nye ikoner også:

Brukte dette scriptet for å se om denne PR-en ville fjerne noen ikoner. AFAIK gjør den ikke det.

package main

import (
	"fmt"
	"os"
	"path/filepath"
	"strings"
)

// SvgInfo stores information about an SVG file
type SvgInfo struct {
	name     string // filename without extension
	fullPath string // full path relative to root folder
}

func main() {
	// Define folder paths
	oldFolder := "icons_old"
	newFolder := "icons_new"
	fmt.Printf("Comparing folders:\nOld folder: %s\nNew folder: %s\n\n", oldFolder, newFolder)

	// Recursively get SVG files from both folders
	oldSvgs, err := getSvgFilesRecursive(oldFolder)
	if err != nil {
		fmt.Printf("Error reading old folder: %v\n", err)
		return
	}

	newSvgs, err := getSvgFilesRecursive(newFolder)
	if err != nil {
		fmt.Printf("Error reading new folder: %v\n", err)
		return
	}

	fmt.Printf("Old folder contains %d SVG files.\n", len(oldSvgs))
	fmt.Printf("New folder contains %d SVG files.\n\n", len(newSvgs))

	// Find missing and new SVGs
	missingSvgs := findMissingFiles(oldSvgs, newSvgs)
	newIcons := findMissingFiles(newSvgs, oldSvgs)

	// Output results
	if len(missingSvgs) > 0 {
		fmt.Printf("SVGs in '%s' not found in corresponding paths in '%s' (%d files):\n",
			oldFolder, newFolder, len(missingSvgs))
		for _, svg := range missingSvgs {
			fmt.Printf("%s\n", svg.fullPath)
		}
		fmt.Println()
	} else {
		fmt.Println("All SVGs in the old folder are present in the corresponding paths in the new folder.\n")
	}

	if len(newIcons) > 0 {
		fmt.Printf("New SVGs in '%s' not found in corresponding paths in '%s' (%d files):\n",
			newFolder, oldFolder, len(newIcons))
		for _, svg := range newIcons {
			fmt.Printf("%s\n", svg.fullPath)
		}
		fmt.Println()
	} else {
		fmt.Println("No new SVGs found in the new folder that are not in the old folder.\n")
	}

	fmt.Println("Comparison complete.")
}

// getSvgFilesRecursive recursively searches a folder for SVG files and returns a map of their info
func getSvgFilesRecursive(rootFolder string) (map[string]SvgInfo, error) {
	svgMap := make(map[string]SvgInfo)

	err := filepath.Walk(rootFolder, func(path string, info os.FileInfo, err error) error {
		if err != nil {
			return err
		}

		if !info.IsDir() && strings.HasSuffix(strings.ToLower(info.Name()), ".svg") {
			// Get the relative path from the root folder
			relPath, err := filepath.Rel(rootFolder, path)
			if err != nil {
				return err
			}

			name := strings.ToLower(strings.TrimSuffix(info.Name(), filepath.Ext(info.Name())))
			// Use the relative path as the key to maintain folder structure comparison
			key := filepath.ToSlash(filepath.Dir(relPath)) + "/" + name

			svgMap[key] = SvgInfo{
				name:     name,
				fullPath: filepath.ToSlash(relPath),
			}
		}
		return nil
	})

	if err != nil {
		return nil, err
	}

	return svgMap, nil
}

// findMissingFiles returns elements in a that are not in b, considering full paths
func findMissingFiles(a, b map[string]SvgInfo) []SvgInfo {
	var missing []SvgInfo
	for key, info := range a {
		if _, found := b[key]; !found {
			missing = append(missing, info)
		}
	}
	return missing
}

Comparing folders:
Old folder: icons_old
New folder: icons_new

Old folder contains 3479 SVG files.
New folder contains 3799 SVG files.

All SVGs in the old folder are present in the new folder.

New SVGs in 'icons_new' not found in 'icons_old' (320 files):
bookmark_bag.svg
document_search.svg
contrast_circle.svg
scooter.svg
touch_double.svg
slab_serif.svg
diagonal_line.svg
format_textdirection_vertical.svg
reset_settings.svg
laptop_car.svg
tv_displays.svg
save_clock.svg
reset_focus.svg
network_intelligence.svg
edit_arrow_up.svg
bookmark_heart.svg
modeling.svg
owl.svg
adaptive_audio_mic_off.svg
receipt_long_off.svg
spatial_speaker.svg
keyboard_lock.svg
map_search.svg
replace_image.svg
emoji_language.svg
reset_white_balance.svg
cards_star.svg
books_movies_and_music.svg
database_upload.svg
eye_tracking.svg
filter_arrow_right.svg
siren_open.svg
folder_check_2.svg
road.svg
delivery_dining.svg
keep_pin.svg
trackpad_input_3.svg
closed_caption_add.svg
lightbulb_2.svg
face_right.svg
watch_check.svg
currency_rupee_circle.svg
railway_alert_2.svg
metro.svg
desktop_cloud.svg
two_pager_store.svg
arrow_menu_open.svg
graph_2.svg
videocam_alert.svg
desktop_landscape_add.svg
offline_pin_off.svg
speed_1_7x.svg
identity_platform.svg
smartphone_camera.svg
text_compare.svg
fit_page_width.svg
mail_off.svg
directions_railway_2.svg
search_insights.svg
tv_next.svg
keyboard_lock_off.svg
siren.svg
add_2.svg
reset_shutter_speed.svg
search_check_2.svg
upi_pay.svg
eraser_size_2.svg
convert_to_text.svg
delivery_truck_bolt.svg
view_apps.svg
arrows_input.svg
ink_selection.svg
av1.svg
face_shake.svg
database_search.svg
desktop_cloud_stack.svg
automation.svg
power_settings_circle.svg
trackpad_input.svg
mic_alert.svg
graph_4.svg
page_footer.svg
timer_play.svg
speed_1_75.svg
book_4_spark.svg
bookmark_check.svg
timer_5.svg
tile_medium.svg
add_row_below.svg
history_2.svg
boat_bus.svg
password_2.svg
landscape_2_off.svg
arrows_output.svg
pinboard.svg
contextual_token.svg
stack_hexagon.svg
mouse_lock_off.svg
handheld_controller.svg
folder_match.svg
rate_review_rtl.svg
touch_long.svg
float_portrait_2.svg
fingerprint_off.svg
drive_export.svg
table_eye.svg
docs.svg
eraser_size_4.svg
speed_0_25.svg
monorail.svg
file_json.svg
boat_railway.svg
arrow_upload_ready.svg
encrypted_minus_circle.svg
wifi_calling_bar_3.svg
inbox_text.svg
speed_1_5x.svg
add_triangle.svg
funicular.svg
siren_question.svg
vo2_max.svg
reset_shadow.svg
contrast_square.svg
flag_check.svg
book_6.svg
category_search.svg
24fps_select.svg
bookmark_star.svg
expansion_panels.svg
widget_width.svg
file_png.svg
replace_audio.svg
splitscreen_landscape.svg
hourglass_pause.svg
avc.svg
lowercase.svg
flag_2.svg
motion_play.svg
clock_arrow_up.svg
float_landscape_2.svg
credit_card_clock.svg
tab_inactive.svg
timer_5_shutter.svg
add_column_left.svg
password_2_off.svg
hearing_aid.svg
traffic_jam.svg
table_edit.svg
sync_arrow_down.svg
identity_aware_proxy.svg
planet.svg
simulation.svg
flyover.svg
smart_card_reader_off.svg
encrypted_off.svg
select_window_2.svg
unpin.svg
cloud_lock.svg
tile_small.svg
view_real_size.svg
chevron_forward.svg
reset_iso.svg
fork_spoon.svg
square_dot.svg
voice_selection_off.svg
arrow_menu_close.svg
unknown_7.svg
clock_arrow_down.svg
wifi_calling_bar_2.svg
tooltip_2.svg
cable_car.svg
hov.svg
eraser_size_1.svg
host.svg
moped.svg
list_alt_check.svg
trackpad_input_2.svg
edit_audio.svg
add_diamond.svg
orbit.svg
head_mounted_device.svg
face_down.svg
desktop_portrait.svg
wifi_calling_bar_1.svg
split_scene.svg
match_case_off.svg
sync_desktop.svg
chevron_backward.svg
adaptive_audio_mic.svg
speed_0_75.svg
titlecase.svg
contextual_token_add.svg
devices_fold_2.svg
uppercase.svg
keep.svg
hard_disk.svg
database_off.svg
landscape_2.svg
eraser_size_5.svg
format_quote_off.svg
hourglass_arrow_down.svg
widget_medium.svg
speed_1_2x.svg
gondola_lift.svg
movie_off.svg
trolley_cable_car.svg
borg.svg
guardian.svg
encrypted_add_circle.svg
unpaved_road.svg
tile_large.svg
encrypted_add.svg
id_card.svg
file_map_stack.svg
timer_arrow_down.svg
money_bag.svg
transit_ticket.svg
thermostat_arrow_up.svg
share_eta.svg
tablet_camera.svg
folder_info.svg
skull_list.svg
multiple_airports.svg
serif.svg
cardio_load.svg
files.svg
file_export.svg
keep_public.svg
music_note_add.svg
sync_arrow_up.svg
open_run.svg
threat_intelligence.svg
folder_eye.svg
gif_2.svg
arrow_upload_progress.svg
hourglass_arrow_up.svg
replace_video.svg
desktop_landscape.svg
flowchart.svg
arrow_back_2.svg
shift_lock_off.svg
book_ribbon.svg
globe_book.svg
policy_alert.svg
eraser_size_3.svg
script.svg
hearing_aid_disabled.svg
server_person.svg
bookmark_flag.svg
bus_railway.svg
video_camera_back_add.svg
add_row_above.svg
text_up.svg
add_column_right.svg
graph_6.svg
face_left.svg
table_convert.svg
page_header.svg
speed_0_5x.svg
combine_columns.svg
speed_1_25.svg
reset_brightness.svg
delivery_truck_speed.svg
dashboard_2.svg
fitness_tracker.svg
rotate_auto.svg
edit_arrow_down.svg
timer_arrow_up.svg
graph_1.svg
poker_chip.svg
network_intel_node.svg
group_search.svg
speed_camera.svg
expension_panels.svg
graph_3.svg
stairs_2.svg
hand_gesture_off.svg
view_object_track.svg
folder_code.svg
fullscreen_portrait.svg
smart_card_reader.svg
pinboard_unread.svg
folder_check.svg
thermostat_arrow_down.svg
bike_lane.svg
cadence.svg
bar_chart_off.svg
chat_paste_go_2.svg
search_activity.svg
animated_images.svg
crown.svg
mouse_lock.svg
cloud_alert.svg
recenter.svg
face_up.svg
speed_0_7x.svg
multimodal_hand_eye.svg
keep_off.svg
screenshot_frame_2.svg
face_nod.svg
bike_dock.svg
tab_close_inactive.svg
highlight_alt.svg
shopping_bag_speed.svg
masked_transitions_add.svg
graph_5.svg
chess_pawn.svg
arrow_warm_up.svg
fit_page_height.svg
frame_person_mic.svg
speed_0_2x.svg
widget_small.svg
splitscreen_portrait.svg
arrow_cool_down.svg
cognition_2.svg
touch_triple.svg
brick.svg
siren_check.svg
timer_pause.svg
watch_vibration.svg

Comparison complete.

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2477.westeurope.2.azurestaticapps.net

[HeleneKassandra]

Hvordan klarer dere å regne ut riktig Optical size?
PR'en er så stor så github krasjer når jeg prøver å se

[antidecaf]

Vanskelig å navigere denne PR-en, men ikonene er så vidt jeg kan se i riktige størrelser nå. :)

For at de skal vises riktig uten whitespace må også variablene for størrelser i theme.less oppdateres.

[hagenek]

Hvordan klarer dere å regne ut riktig Optical size? PR'en er så stor så github krasjer når jeg prøver å se

Det blir optical size fra Material Symbols for sm, md og xl. lg blir resizet ned fra xl, men det kommer ikke til å ha store konsekvenser, og hensynet til konsistens i design-systemet går over optimal optisk størrelse. Man kan også justere ved å endre weight.

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2477.westeurope.2.azurestaticapps.net