Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantiske farger accordion #2481

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

tuva-odegard
Copy link
Contributor

Som en del av #2373 og #2392 oppdaterer vi nå alle komponenter til å ta i bruk semantiske farger. Skal fungere i light mode, accent mode, dark mode og accent dark mode.

Endringene i Figma kan finne i DS 2.0 Core https://www.figma.com/design/0trRkHBkdZ6emkhwPJAJMy/DS-2.0-Core?node-id=27392-90583&m=dev.

Fint om @dagfrode eller noen andre utenfor teamet kan teste i firefox!

@tuva-odegard tuva-odegard requested a review from a team as a code owner January 20, 2025 08:30
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2481.westeurope.2.azurestaticapps.net

dagfrode
dagfrode previously approved these changes Jan 20, 2025
Copy link
Contributor

@dagfrode dagfrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut. Fungerer bra i FF :)

image

@tuva-odegard tuva-odegard force-pushed the semantiske-farger-accordion branch 3 times, most recently from 81e2216 to d2101ae Compare January 20, 2025 12:33
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2481.westeurope.2.azurestaticapps.net

BREAKING CHANGE: Nye semantiske farger. Slettet theme.less. Ingen
endringer nødvendig
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2481.westeurope.2.azurestaticapps.net

@tuva-odegard tuva-odegard force-pushed the semantiske-farger-accordion branch from d2101ae to 294d339 Compare January 20, 2025 12:35
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2481.westeurope.2.azurestaticapps.net

2 similar comments
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2481.westeurope.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2481.westeurope.2.azurestaticapps.net

@tuva-odegard
Copy link
Contributor Author

Har oppdatert. Skal nå fungere med animasjon på bakgrunnsfarge på hover. Og har slettet fila ffe-accordion som bare tok inn theme før, men følte ikke vi trengte den.
Har også lagt det inn som breaking change.

@HeleneKassandra
Copy link
Contributor

Fikser denne tilfeldigvis feilen med at storybook ikke vil bygge pga "required not defined"? :D

@tuva-odegard
Copy link
Contributor Author

@HeleneKassandra Ja! :D

Copy link
Contributor

@dagfrode dagfrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🦊 ✔️

@tuva-odegard tuva-odegard merged commit 2e4f92c into develop Jan 20, 2025
3 checks passed
@tuva-odegard tuva-odegard deleted the semantiske-farger-accordion branch January 20, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants