Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export forcing!, drag!, etc for extending those with fewer conflicts #426

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

milankl
Copy link
Member

@milankl milankl commented Dec 28, 2023

To always trigger this error when people incorrectly try to extend forcing and drag

julia> forcing!(x) = x
ERROR: error in method definition: function SpeedyWeather.forcing! must be explicitly imported to be extended

This is hopefully more verbose and avoids potential naming conflicts as otherwise a forcing! can be defined in global which is indepedendent (and therefore confusing!) from the one in the SpeedyWeather module

@milankl milankl added the user interface 🎹 How users use our user interface label Dec 28, 2023
@milankl milankl merged commit 56b1fc9 into main Jan 5, 2024
3 checks passed
@milankl milankl deleted the mk/forcing branch January 24, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user interface 🎹 How users use our user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant