Merge pull request #109 from SpiNNakerManchester/python3.12

Python3.12

.github/workflows/c_actions.yml

@@ -33,11 +33,11 @@ jobs:
       uses: ./support/actions/apt-get-install
       with:
         packages: doxygen gcc-arm-none-eabi
-    - name: Configure Python 3.8
+    - name: Configure Python 3.12
       # Note: Python is needed for spinn_utilities.make_tools when building
       uses: actions/setup-python@v2
       with:
-        python-version: 3.8
+        python-version: 3.12
 
     - name: Set environment variables
       run: |

.github/workflows/python_actions.yml

@@ -22,7 +22,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11"]
+        python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
     steps:
     # Check out the code and critical support code
     - name: Checkout
@@ -82,7 +82,7 @@ jobs:
         exitcheck: 39
 
     - name: Run rat copyright enforcement
-      if: matrix.python-version == 3.8
+      if: matrix.python-version == 3.12
       uses: ./support/actions/check-copyrights
       with:
         config_file: rat_asl20.xml
@@ -94,5 +94,5 @@ jobs:
     #    base-path: ${{ env.CODE_PATHS }}
 
     - name: Validate CITATION.cff
-      if: matrix.python-version == 3.8
+      if: matrix.python-version == 3.12
       uses: dieghernan/cff-validator@main

python_models8/connectors/my_connector.py

@@ -28,8 +28,14 @@ def __init__(self, weights=0.0, delays=1, allow_self_connections=True
 
     @overrides(AbstractConnector.get_delay_maximum)
     def get_delay_maximum(self, synapse_info):
+        # TODO call self._get_delay_maximum if needed
         return 16
 
+    @overrides(AbstractConnector.get_delay_minimum)
+    def get_delay_minimum(self, synapse_info):
+        # TODO call self._get_delay_minimum if needed
+        return 1
+
     @overrides(AbstractGenerateConnectorOnHost.create_synaptic_block)
     def create_synaptic_block(
             self, post_slices, post_vertex_slice, synapse_type, synapse_info):

python_models8/neuron/plasticity/stdp/timing_dependence/my_timing_dependence.py

@@ -12,8 +12,7 @@ class MyTimingDependence(AbstractTimingDependence):
         "_a_minus",
         "_a_plus",
         "_my_depression_parameter",
-        "_my_potentiation_parameter",
-        "_synapse_structure"]
+        "_my_potentiation_parameter"]
 
     NUM_PARAMETERS = 2
 
@@ -27,13 +26,13 @@ def __init__(
 
             A_plus=0.01, A_minus=0.01):
 
+        # TODO: Update to match the synapse structure in the C code
+        super().__init__(SynapseStructureWeightOnly())
+
         # TODO: Store any parameters
         self._my_potentiation_parameter = my_potentiation_parameter
         self._my_depression_parameter = my_depression_parameter
 
-        # TODO: Update to match the synapse structure in the C code
-        self._synapse_structure = SynapseStructureWeightOnly()
-
         # Are these in the c code?
         self._a_plus = A_plus
         self._a_minus = A_minus
@@ -113,12 +112,6 @@ def write_parameters(
     def get_parameter_names(self):
         return ['my_potentiation_parameter', 'my_depression_parameter']
 
-    @property
-    def synaptic_structure(self):
-        """ Get the synaptic structure of the plastic part of the rows
-        """
-        return self._synapse_structure
-
     @property
     def A_plus(self):
         return self._a_plus

setup.cfg

@@ -30,19 +30,19 @@ classifiers =
         Operating System :: Microsoft :: Windows
         Operating System :: MacOS
         Programming Language :: Python :: 3
-        Programming Language :: Python :: 3.7
         Programming Language :: Python :: 3.8
         Programming Language :: Python :: 3.9
         Programming Language :: Python :: 3.10
         Programming Language :: Python :: 3.11
+        Programming Language :: Python :: 3.12
 maintainer = SpiNNakerTeam
 maintainer_email = [email protected]
 keywords =
         spinnaker
         pynn
 
 [options]
-python_requires = >=3.7, <4
+python_requires = >=3.8, <4
 packages = find:
 zip_safe = True
 include_package_data = True

setup.py

@@ -12,9 +12,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import distutils.dir_util
 from setuptools import setup
 import os
+import shutil
 import sys
 
 
@@ -26,9 +26,9 @@
         this_dir = os.path.dirname(os.path.abspath(__file__))
         build_dir = os.path.join(this_dir, "build")
         if os.path.isdir(build_dir):
-            distutils.dir_util.remove_tree(build_dir)
+            shutil.rmtree(build_dir)
         egg_dir = os.path.join(
             this_dir, "sPyNNaker8NewModelTemplate.egg-info")
         if os.path.isdir(egg_dir):
-            distutils.dir_util.remove_tree(egg_dir)
+            shutil.rmtree(egg_dir)
     setup()