Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vanilla on premium bungee #3650

Closed

Conversation

Outfluencer
Copy link
Collaborator

Set offline uuid in the LoginSuccess packet if online-mode=true and ipforward=false (this means we want to support vanilla)
Also dont change the offline uuids received from the server to online uuids otherwise the player is not able to chat as he can't verify the chatmessages

Closes #3604

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Apr 13, 2024

the client now receives every player as premium player but with an offline uuid, skins and capes are still visible
In bungeecord the uuid still remains online, no permission systems are affected, everything done in this pr is packet rewriting

@md-5
Copy link
Member

md-5 commented Apr 13, 2024

Thanks, this is what I had in mind.

EntityMap_1_16_2 looks OK already to me, but would be grateful for you to confirm?

@Outfluencer
Copy link
Collaborator Author

I think we could just check for vanilla and return if so as we dont want the client to receive the online uuid.
As i understand we are rewriting an offline uuid to an online uuid, but in vanilla we just want to keep the offline uuid, while i was testing with an 1.20.4 client i saw no exception in the client or issues in generell, but maybe this should be changed

@Outfluencer
Copy link
Collaborator Author

found out this is importet for old versions like 1.8.8 otherwise players are invisible

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Apr 14, 2024

now we don't replace offline uuid to online uuid if onlinemod and !ip-forward in spawnplayer packet

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Apr 16, 2024

i think a getNetworkingId field/method would be a good idea instead of checking for online mode and ip forward everytime
also changing this values in the config and reloading bungeecord would break everythin now, with a networking uuid this would also apply for new players that are joining so not everything would be broken

@Outfluencer Outfluencer marked this pull request as draft April 16, 2024 07:08
@Outfluencer
Copy link
Collaborator Author

not tested for now, but i think i'll do it like that

Outfluencer@162bc1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants