Highly optimize Varint21FrameDecoder

[Outfluencer]

Removed byte[] alloc and reduce loops by using ByteBuf.forEachByte only ones and than parsing the Varint with bitshifting from the buffer

[Outfluencer]

can we also remove the direct IO buffers info?

[Outfluencer]

That is extremly disrespectfull

i have written the code myself it took me about a hour

[Outfluencer]

That is extremly disrespectfull
i have written the code myself it took me about a hour

Your code reminded me about one of the many velocity varint21 frame decoder variations it has seen over time. Sorry that I jumped to quickly to this conclusion, did not checked this and just wrote too early.

Edit: I do not agree with your opinion, that my comment was disrespectful.

Simply assuming that the code is copied and asking for the license from the rightful owner is disrespectful in my opinion.

[Outfluencer]

Also if it wasn‘t disrespectful why delete it

[Outfluencer]

i think i got a too good view on you with how u actually do useful pr's here, unfortunaly it seems you & your friend circle still miss some crucial skills. i will stop interacting with you starting now

I actually don't know what "friend circle" you mean and what "skills" i do miss, anyways this inappropriate on github.
I don't even think you know friends of mine.

It seems like you have a personal issue with me, or somebody i know. If so you got my discord tag, we can talk about it in private

[andreasdc]

Keep it friendly guys. By the way is it possible to add some security checks to the decoder with this patch?

[Outfluencer]

Keep it friendly guys. By the way is it possible to add some security checks to the decoder with this patch?

what do you mean by security checks

[xism4]

i think i got a too good view on you with how u actually do useful pr's here, unfortunaly it seems you & your friend circle still miss some crucial skills. i will stop interacting with you starting now

I actually don't know what "friend circle" you mean and what "skills" i do miss, anyways this inappropriate on github. I don't even think you know friends of mine.

It seems like you have a personal issue with me, or somebody i know. If so you got my discord tag, we can talk about it in private

And if it's not the skills, it's your lack of veracity.

[andreasdc]

Keep it friendly guys. By the way is it possible to add some security checks to the decoder with this patch?

what do you mean by security checks

Some limiters for example, so it can't be bypassed by some naughty users.

[Outfluencer]

Keep it friendly guys. By the way is it possible to add some security checks to the decoder with this patch?

what do you mean by security checks

Some limiters for example, so it can't be bypassed by some naughty users.

I dont understand what can be bypassed here, and i dont know what you mean by limits, its a Varint21FrameDecoder, the limit is in the name of the decoder