Merge pull request #2727 from zm711/neg-spikes-v2

Make sure `has_exceeding_spikes` also checks for negative spikes.

src/spikeinterface/core/waveform_tools.py

@@ -696,6 +696,8 @@ def has_exceeding_spikes(recording, sorting):
         if len(spike_vector_seg) > 0:
             if spike_vector_seg["sample_index"][-1] > recording.get_num_samples(segment_index=segment_index) - 1:
                 return True
+            if spike_vector_seg["sample_index"][0] < 0:
+                return True
     return False
 
 

src/spikeinterface/curation/remove_excess_spikes.py

@@ -62,7 +62,8 @@ def _custom_cache_spike_vector(self) -> None:
         for segment_index in range(num_segments):
             spike_vector = parent_spike_vector[segments_bounds[segment_index] : segments_bounds[segment_index + 1]]
             end = np.searchsorted(spike_vector["sample_index"], self._num_samples[segment_index])
-            list_spike_vectors.append(spike_vector[:end])
+            start = np.searchsorted(spike_vector["sample_index"], 0, side="left")
+            list_spike_vectors.append(spike_vector[start:end])
 
         spike_vector = np.concatenate(list_spike_vectors)
         self._cached_spike_vector = spike_vector

src/spikeinterface/curation/tests/test_remove_excess_spikes.py

@@ -22,7 +22,7 @@ def test_remove_excess_spikes():
         times_segment = np.array([], dtype=int)
         labels_segment = np.array([], dtype=int)
         for unit in range(num_units):
-            neg_spike_times = np.random.randint(-50, 0, num_neg_spike_times_per_segment)
+            neg_spike_times = np.random.randint(-50, -1, num_neg_spike_times_per_segment)
             spike_times = np.random.randint(0, num_samples, num_spikes)
             last_samples_spikes = (num_samples - 1) * np.ones(num_num_samples_spikes_per_segment, dtype=int)
             num_samples_spike_times = num_samples * np.ones(num_num_samples_spikes_per_segment, dtype=int)