Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in get_repolarization_slope with wrong index type #2432

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Jan 24, 2024

In the low-level implementation of get_repolarization_slope line 471/3:

       trough_idx = get_trough_and_peak_idx(template_single)

This will return a tuple instead of an int, which will cause the slicing to break later in the function.

Since the high level call for template metrics supplies trough_idx and peak_idx this bug would only appear if someone tried to call the low level function by itself.

Also edited some docstrings.

@zm711 zm711 added bug Something isn't working postprocessing Related to postprocessing module labels Jan 24, 2024
@alejoe91 alejoe91 added this to the 0.100.0 milestone Jan 26, 2024
@alejoe91
Copy link
Member

Thanks Zach!

@alejoe91 alejoe91 merged commit 1735076 into SpikeInterface:main Jan 29, 2024
11 checks passed
@zm711 zm711 deleted the template-metrics branch January 29, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working postprocessing Related to postprocessing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants