Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Probe __eq__ in Template Object __eq__ #2457

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Feb 1, 2024

Uses the new developed dunder equality method of the Probe object:

SpikeInterface/probeinterface#248

Requires:
#2458

@h-mayorquin h-mayorquin self-assigned this Feb 1, 2024
@h-mayorquin h-mayorquin added the core Changes to core module label Feb 1, 2024
@h-mayorquin h-mayorquin force-pushed the use_probe_eq_comaprison_in_template_object branch from 4dc1a64 to e454bdf Compare February 1, 2024 20:43
@h-mayorquin h-mayorquin marked this pull request as ready for review February 1, 2024 22:33
@h-mayorquin h-mayorquin changed the title Use probe equality in Template Object equality Use Probe __eq__ in Template Object __eq__ Feb 1, 2024
@alejoe91 alejoe91 added this to the 0.100.0 milestone Feb 2, 2024
@alejoe91 alejoe91 merged commit e632d46 into SpikeInterface:main Feb 2, 2024
11 checks passed
@h-mayorquin h-mayorquin deleted the use_probe_eq_comaprison_in_template_object branch February 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants