Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NWB: do not load group property link #2464

Merged
merged 1 commit into from
Feb 5, 2024
Merged

NWB: do not load group property link #2464

merged 1 commit into from
Feb 5, 2024

Conversation

alejoe91
Copy link
Member

@alejoe91 alejoe91 commented Feb 5, 2024

The group column is a link to the ElectrodeGroup object, so it's better to load group_names only to retrieve groups.

Also added a small fix to load the brainn_area property

@alejoe91 alejoe91 added the extractors Related to extractors module label Feb 5, 2024
@alejoe91 alejoe91 added this to the 0.100.0 milestone Feb 5, 2024
@samuelgarcia samuelgarcia merged commit 17234db into SpikeInterface:main Feb 5, 2024
11 checks passed
@alejoe91 alejoe91 deleted the minor-nwb-fix branch April 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelgarcia samuelgarcia samuelgarcia approved these changes

Assignees
No one assigned
Labels
extractors Related to extractors module
Projects
None yet
Milestone
0.100.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alejoe91 @samuelgarcia