Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the discussion we had in #2397
Indeed there is a bug in the Gaussian filter implementation, which matters if
freq_min
andfreq_max
are close to one another, or even if the min is above the maxHere is a quick code to check for the bug:
Here is what the plot looks like before the patch:
And what is looks like after this patch:
We can see the impulse is no longer going in the other direction, and there is less signal overall (which is expected)
Thanks @TomBugnon for pointing out the issue!