Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix singularity issue in deleting py_user_folder #2493

Merged
merged 3 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/spikeinterface/core/baserecordingsnippets.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ def set_channel_locations(self, locations, channel_ids=None):
if self.get_property("contact_vector") is not None:
raise ValueError("set_channel_locations(..) destroy the probe description, prefer set_probes(..)")
self.set_property("location", locations, ids=channel_ids)
self.set_dummy_probe_from_locations(locations)
alejoe91 marked this conversation as resolved.
Show resolved Hide resolved

def get_channel_locations(self, channel_ids=None, axes: str = "xy"):
if channel_ids is None:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,4 @@ def test_klusta(run_kwargs):

if __name__ == "__main__":
kwargs = generate_run_kwargs()
test_combinato(kwargs)
test_spykingcircus(kwargs)
alejoe91 marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion src/spikeinterface/sorters/runsorter.py
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ def run_sorter_container(
os.remove(parent_folder / "in_container_params.json")
os.remove(parent_folder / "in_container_sorter_script.py")
if mode == "singularity":
shutil.rmtree(py_user_base_folder)
shutil.rmtree(py_user_base_folder, ignore_errors=True)

# check error
output_folder = Path(output_folder)
Expand Down
Loading