Cleanup of modules gallery docs (post SorterAnalyzer) #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xarray is a big stuff for core dep. I think I would prefer avoid it. |
samuelgarcia
reviewed
Mar 6, 2024
pyproject.toml
Outdated
| @@ -24,6 +24,7 @@ dependencies = [ | |||
| "threadpoolctl>=3.0.0", | |||
| "tqdm", | |||
| "zarr>=0.2.16", | |||
| "xarray", | |||
There was a problem hiding this comment.
Honestly I would prefer to avoid this.
We can add it for doc building.
There was a problem hiding this comment.
Done. Removed from core. added back to full and to docs.
|
But you have it in SorterAnalyzer for zarr format. So it's already in core if someone wants to use zarr format. But for this PR I can switch it back to just be in the docs building. |
|
Thanks for the grammar and typos. I can't beleive I did so much mistake. |
|
It's the curse of someone who types so fast, the examples can't keep up with your mind :) . |
samuelgarcia
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelgarcia since you've added zarr into core for SorterAnalyzer we need it to be in base dependencies.... The documentation update broke one of the example code because when you did a zarr with SorterAnalyzer the doc environment didn't have xarray. We could also revert that change and change the example, but at this point it is probably best just to add xarray to core no?
(Also I see for the examples you're using the list input for the SorterAnalyzer.compute()... Nice)