Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for excess spikes error in FrameSliceSorting. #2604

Merged

Conversation

h-mayorquin
Copy link
Collaborator

From the discussion here:
#2573 (comment)

I was kind of recluctanct to add "could indicate a bug on the sorter" as this is a very general function but I guess a sorting object can only come from sorter so...

@h-mayorquin h-mayorquin added the documentation Improvements or additions to documentation label Mar 19, 2024
@h-mayorquin h-mayorquin self-assigned this Mar 19, 2024
@zm711
Copy link
Collaborator

zm711 commented Mar 20, 2024

I think you're right to be a little wary. The only thing I could think of is maybe a rounding error. Like if the sampling_rate is 30k, but because we store it as a float it ends up being 30_000.000002434 and so when we multiply that by the real big sample numbers it leads to some error in certain sorters. But I guess we would have to track down these failures and see if they are within a few samples of the end of the recording or if they seem to have random times. Other than a rounding error everything else would point to an issue with the sorter, no?

@alejoe91
Copy link
Member

Yeah it must be a problem with the sorter!

@zm711
Copy link
Collaborator

zm711 commented Mar 25, 2024

Maybe you guys have a better sense, but does this excessive spikes only occur for Kilosort and do you think it could be due to the fact that Kilosort can add padding to the recording? So maybe it is accidentally returning a padded frame (for whatever reason) which would then be after the recording since the recording doesn't have that padding? --That's still a problem at the sorter level, but like @h-mayorquin, I'm just curious what the root cause is.

@alejoe91 alejoe91 merged commit 2b80f16 into SpikeInterface:main Mar 27, 2024
9 of 11 checks passed
@h-mayorquin h-mayorquin deleted the improve_documentation_frame_slice branch March 27, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants