Load pca from waveform extractor and waveform from Zarr #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samuelgarcia this needs to be squashed and merged! |
| with open(params_file, "r") as f: | ||
| params = json.load(f) | ||
| n_components = params["n_components"] | ||
| n_channels = len(rec_attributes["channel_ids"]) |
There was a problem hiding this comment.
Can you check that in the old format it was sparse or not ?
There was a problem hiding this comment.
even if the old format is sparse, the components are always saved in "full". Sparsity is only used to skip channels during PCA compute and project
src/spikeinterface/core/waveforms_extractor_backwards_compatibility.py
Outdated
Show resolved
Hide resolved
…load-pca-from-waveform-extractor
|
@samuelgarcia ready to merge |
samuelgarcia
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelgarcia
Implemented the missing pieces for bakward compatibility. Added 2 very small folders (< 1MB) in total. for testing. Ok?