Handle ms_before and ms_after difference between waveforms and template extensions #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+305
to
+311
| if ms_before != ms_before_waveforms or ms_after != ms_after_waveforms: | ||
| raise ValueError( | ||
| "templates extension parameters are inconsistent with the waveforms extension. \n" | ||
| f"waveform extension ms_before={ms_before_waveforms} ms_after={ms_after_waveforms} \n" | ||
| f"templates extension ms_before={ms_before} ms_after={ms_after}." | ||
| ) | ||
|
|
There was a problem hiding this comment.
I think I prefered the previous behavior:
- use parameters when compute directly
- ignore parameters and hinertis from waveforms extension when this exists.
There was a problem hiding this comment.
I think privilegin the waveform is a fine default but you should let users know this otherwise they will be confused like me . My other proposal above was a warning when they don't match. What do you think?
|
@h-mayorquin after discussing with Sam, we think it's ok that waveforms control the ms_before/after, let's just be clearer with this in the docs without too many warnings |
|
All right. Where should this behavior be written? |
|
@h-mayorquin adding a comment here in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They might be different, we can either raise an error like here or change to a warning and priviledge the ones of the waveform as we are doing right now.
What do you guys think?