Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports in ibl test #2939

Merged
merged 2 commits into from
May 30, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented May 30, 2024

Remove unused tkinter import on ibl that is breaking tests on mac.

@h-mayorquin h-mayorquin self-assigned this May 30, 2024
@h-mayorquin h-mayorquin added the testing Related to test routines label May 30, 2024
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@h-mayorquin
Copy link
Collaborator Author

@alejoe91 @samuelgarcia I will abuse my power and merge this. This is just an unused import that is getting that causes problems in mac.

@h-mayorquin h-mayorquin merged commit 9a12ac9 into SpikeInterface:main May 30, 2024
2 of 11 checks passed
@h-mayorquin h-mayorquin deleted the remove_tkinter_import branch May 30, 2024 14:36
@alejoe91 alejoe91 added the hackathon-24 Contributions during the SpikeInterface Hackathon May 24 label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon-24 Contributions during the SpikeInterface Hackathon May 24 testing Related to test routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants