-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extractors for SiNAPS Research Platform #2952
Conversation
Add an H5 extractor for SiNAPS Research Platform
@NinelK can you allow edits from maintainers? The pre-commit bot failed to refactor the code according to black |
it was allowed in the settings on the side, not sure why pre-comit.ci can not push. |
from ..preprocessing import UnsignedToSignedRecording | ||
|
||
|
||
class SinapsResearchPlatformH5RecordingExtractor_Unsigned(BaseRecording): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just apply the unsigned_to_signed in the get_traces, which is simpler to read and will get rid of the complex class interplay. I can implement that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@NinelK after discussing with @samuelgarcia, we decided that in this case it's worth adding the unsigned to signed scaling directly to the SinapsH5Extractors (avoiding that class trick, which makes it less readable). Also moved everything to a single file and cleaned docs and helper functions. Ready to merge on my end |
@NinelK can you test it one more time on your side? I don't have h5 test data |
I'm on it now |
All works now, just fixed 1 issue with a missing argument |
Contains extractors from binary format (raw + filtered + aux channels) as well as an additional extractor from *.h5 format (only filtered channels)