Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cron job for installation_tips #3038

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Jun 18, 2024

The mac install has been failing for the past few months.... Based on the instructions it seems like the solution is to
provide miniconda version so it is downloaded for safety on Mac.

https://github.com/conda-incubator/setup-miniconda

Also updated to v3. Not sure if we want me to switch to push to test or if we just want to merge and then fix after the next cron job if there is a problem?

@zm711 zm711 added the continuous integration Related to CI label Jun 18, 2024
@zm711 zm711 requested a review from h-mayorquin June 18, 2024 20:06
@zm711
Copy link
Collaborator Author

zm711 commented Jun 18, 2024

I'm not sure why Mac would randomly need miniconda-latest but based on my reading of the error this is the fix. As the CI wizard could you doublecheck my reading of the testing error in the Actions and let me know if you think I'm wrong :)

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Question:
will we need this if we get to have #2937

?

@zm711
Copy link
Collaborator Author

zm711 commented Jun 18, 2024

I think so. We have a lot of people who are beginners to python who try to use our installation_tips and this forces us to make sure our tips are not getting too far from 1) the codebase (e.g. SortingAnalyzer change) and 2) standard packages provided in the yaml aren't broken.

It's minimal up keep with a benefit to new-users so I'll happily be the keeper of this action :)

I'm really looking forward to #2937.

@alejoe91 alejoe91 merged commit bdae850 into SpikeInterface:main Jun 19, 2024
11 checks passed
@zm711 zm711 deleted the mac-ci-installation-tips branch June 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants