Sc2 making use of new recording slices #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… into sc2_recording_slices
for more information, see https://pre-commit.ci
|
Depends on #3533, but need to understand why this one is failing |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… into sc2_recording_slices
for more information, see https://pre-commit.ci
… into sc2_recording_slices
for more information, see https://pre-commit.ci
Co-authored-by: Garcia Samuel <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
samuelgarcia
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility for SC2 to make use of the newly introduced recording slices. I.e. while detecting peaks, chunks are shuffled given a seed, and when enough peaks have been collected for clustering, we stop looking for peaks instead of collecting everything, then slicing