Fix plot_sorting_summary widget
#3627
Conversation
alejoe91
changed the title
|
Changed the title! I thought it was a different error, it turns out it was only this: https://github.com/SpikeInterface/spikeinterface/pull/3627/files#diff-66327b100012a00ce020c83d3a3ea191bbb820a0ce3ac02d0328387d14350051R319 Also fixed some tests due to the new kwargs |
alejoe91
changed the title
plot_sorting_summary widget
| backend=backend, | ||
| **self.backend_kwargs[backend], | ||
| ) | ||
| # adding a missing property should raise a warning | ||
| with self.assertWarns(UserWarning): | ||
| sw.plot_sorting_summary( | ||
| self.sorting_analyzer_sparse, | ||
| unit_table_properties=["missing_property"], | ||
| displayed_unit_properties=["missing_property"], |
There was a problem hiding this comment.
is there a reason we changed the naming? this is a breaking change? I never use this argument but do others?
There was a problem hiding this comment.
I think Alessio wants to test if a properties is not present. We decided to not raise an error make user life easier.
There was a problem hiding this comment.
@samuelgarcia I think he means the argument!!!
There was a problem hiding this comment.
I did the change in another PR.
I prefer this one which more easy to understand.
It is back compatible.
Few users I think were using it (only for sorting view).
Now it will be usable with spikeinterface-gui.
|
Cool thanks camarade. |
Fix issue introduces by #3616