Extend si.load capabilities
#3651
Open
+465
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,6 +123,7 @@ test_core = [ | |||
| "pytest", | |||
| "pytest-dependency", | |||
| "psutil", | |||
| "s3fs", # for streaming tests | |||
There was a problem hiding this comment.
This is a big one for core tests no ?
|
Good idea but I am not sure to like the design with try except. |
|
We could also add the Motion object. |
|
And also Template |
|
@alejoe91 : I refactor everything to have more general case. |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
si.loadmagic function to load alsoSortingAnalyzers.In addition, a better logic is implemented to load zarr files, both locally and remotely, including trying to open the folder with different options:
zarr.open/zarr.open_consolidatedandanon False/Truefor remote assets. This simplifies handling of zarr opening everywhere