Begin code tidy, per Flake8 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a start at tidying up some of the basic style changes for #3 using
as a starting point.
This looks like an interesting project, and I'm also interested in https://github.com/Spooky-Manufacturing/QubitDuino and https://github.com/Spooky-Manufacturing/8Q , which I discovered when looking for DIY optical computing projects.
This PR is really a check to see whether these projects are still active, and to find out the current status :)
Hopefully, if all is well, and this PR is useful, I can keep going with Python linting changes and look at tests etc.
FWIW, I was able to run the existing tests as follows:
from
QEDA/srcThese pass:
This is empty:
and these have issue with imports: