Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for Time In Daylight #47

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Add mapping for Time In Daylight #47

merged 3 commits into from
Dec 5, 2024

Conversation

vishnuravi
Copy link
Member

Add mapping for Time In Daylight

♻️ Current situation & Problem

Since iOS 17, HealthKit has added a Time in Daylight quantity type.

⚙️ Release Notes

Adds a mapping for Time in Daylight to a FHIR Observation.

📚 Documentation

Documentation script is updated and new documentation has been generated.

✅ Testing

Unit test added.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (87a9257) to head (21d2b38).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          23       23           
  Lines        1097     1097           
=======================================
  Hits         1017     1017           
  Misses         80       80           

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a9257...21d2b38. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition; looks great!

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Dec 5, 2024
@vishnuravi vishnuravi merged commit a1a7125 into main Dec 5, 2024
9 checks passed
@vishnuravi vishnuravi deleted the time-in-daylight branch December 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants