try to fix locale issues #16
Merged
+11
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Picker, which we currently don't support)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 76.17% 75.98% -0.18%
==========================================
Files 5 5
Lines 386 383 -3
==========================================
- Hits 294 291 -3
Misses 92 92
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to fix locale issues
♻️ Current situation & Problem
In #14, i added the ability to override the Health app's locale, in an attempt to make it easier to test the Health app in a locale-independent manner. (The idea was that you'd be able to simply always specify some fixed locale, which would then be used regardless of where you're running your tests.)
It seems that i flew too close to the sun with this, since it randomly breaks the Health app (even though the approach used was officially recommended), and makes it somehow display only a small subset of all data and catagories.
This PR fixes this, by entirely removing the locale overide.
(The previous version defaulted it to
.current, which I had assumed would be the same as not overriding it, but that doesn't seem to be the case.)⚙️ Release Notes
localeparameter inXCUIApplication.healthApp(locale:); make it a static computed property📚 Documentation
n/a
✅ Testing
n/a
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: