Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation update #59

Closed

Conversation

ZardenSawtooth
Copy link

@ZardenSawtooth ZardenSawtooth commented Aug 27, 2024

Automatically validate the form when a change is detected.

♻️ Current situation & Problem

With the current UX flow, the user is required to find and press the "Validate" button to validate the form. There are a few problem with this flow:

  • Problems remaining undetected until later and take longer to revisit and fix.
  • No real-time feedback for changes to ensure errors are properly addressed.
  • Additional button clicks and workflow steps to ensure a valid form.

⚙️ Release Notes

The validation checks now run automatically whenever a change to the form is detected. Feedback is provided immediately for when validation checks fail.
The download option only allows downloading the form if the form is valid, otherwise displays an error.

📚 Documentation

Now presents feedback any time a change is made to an item that will cause a validation error.
A red outline appears on items in the form builder whenever a validation check fails.
Resolving an error immediately makes the error go away.
The "Validate" check only checks for translation errors.
The download button only allows downloading if there are no errors in the FHIR otherwise it displays an error box.

Performance:
Added caching to reduce the number of times the validation is run if the values remain unchanged to improve performance.

✅ Testing

Auto validation on change

2024-08-28 14-22-48

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer
Copy link
Member

@vishnuravi What do you think about the approaches in this PR? As the PR is in a draft state and a lot of things are missing + it is inactive I would suggest to close it. Nevertheless, the general ideas is nice; what about transforming this into a "good first issue" issue and closing this PR?

@vishnuravi vishnuravi marked this pull request as ready for review January 19, 2025 14:51
@vishnuravi
Copy link
Member

@PSchmiedmayer agree - this PR is a great idea, but since it is unfinished and the fork it is created from is now stale, we will close it and create an issue if someone wishes to pick this up.

@vishnuravi vishnuravi closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants