Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding coding examples for Contact and ContactOption - v2 with signed commits #25

Merged

Conversation

akanshyabhat
Copy link
Contributor

@akanshyabhat akanshyabhat commented Mar 6, 2024

Adding coding examples for Contact and ContactOption - v2 with signed commits

♻️ Current situation & Problem

When I was creating a contact for our application, I was unable to see coding examples. These added examples hope to clarify how someone might build and implement these features.

All of these changes were copied over from my previous pull request for signed commits.

⚙️ Release Notes

N/A

📚 Documentation

  • Improve documentation by showing an example of how to build new Contact as well as custom ContactOptions embedded within larger body of code

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@akanshyabhat
Copy link
Contributor Author

@philippzagar: Here is my updated pull request for the other module! I am unable to request a review from you, but if you would be able to review it that would be great! I have copied over all of the changes that we discussed in the previous PR. You hadn't reviewed those, so that PR is still open so you can see how I changed the code according to your responses. Thank you so much!

@vishnuravi vishnuravi requested a review from philippzagar March 6, 2024 13:04
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (494b776) to head (a148ae5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files           4        4           
  Lines         319      319           
=======================================
  Hits          251      251           
  Misses         68       68           
Files Coverage Δ
Sources/SpeziContact/Models/Contact.swift 100.00% <ø> (ø)
Sources/SpeziContact/Models/ContactOption.swift 86.96% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494b776...a148ae5. Read the comment docs.

Copy link
Member

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @akanshyabhat, just had some minor change requests!

Sources/SpeziContact/Models/Contact.swift Outdated Show resolved Hide resolved
Sources/SpeziContact/Models/Contact.swift Outdated Show resolved Hide resolved
Sources/SpeziContact/Models/ContactOption.swift Outdated Show resolved Hide resolved
@akanshyabhat
Copy link
Contributor Author

@philippzagar I wasn't too sure what you meant by combining the examples - if this is not what you wanted please feel free to let me know!

@akanshyabhat
Copy link
Contributor Author

@philippzagar Thank you so much for the detailed example! I went ahead and made those changes :)

Copy link
Member

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshyabhat Thank you for the PR! Just had 2 minor comments left, please fix them and then you can merge the PR!

Sources/SpeziContact/Models/Contact.swift Outdated Show resolved Hide resolved
Sources/SpeziContact/Models/Contact.swift Outdated Show resolved Hide resolved
@philippzagar philippzagar enabled auto-merge (squash) March 6, 2024 22:41
@philippzagar philippzagar merged commit f0e815e into StanfordSpezi:main Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants