-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding coding examples for Contact and ContactOption - v2 with signed commits #25
Adding coding examples for Contact and ContactOption - v2 with signed commits #25
Conversation
@philippzagar: Here is my updated pull request for the other module! I am unable to request a review from you, but if you would be able to review it that would be great! I have copied over all of the changes that we discussed in the previous PR. You hadn't reviewed those, so that PR is still open so you can see how I changed the code according to your responses. Thank you so much! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 78.69% 78.69%
=======================================
Files 4 4
Lines 319 319
=======================================
Hits 251 251
Misses 68 68
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @akanshyabhat, just had some minor change requests!
@philippzagar I wasn't too sure what you meant by combining the examples - if this is not what you wanted please feel free to let me know! |
@philippzagar Thank you so much for the detailed example! I went ahead and made those changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akanshyabhat Thank you for the PR! Just had 2 minor comments left, please fix them and then you can merge the PR!
Adding coding examples for Contact and ContactOption - v2 with signed commits
♻️ Current situation & Problem
When I was creating a contact for our application, I was unable to see coding examples. These added examples hope to clarify how someone might build and implement these features.
All of these changes were copied over from my previous pull request for signed commits.
⚙️ Release Notes
N/A
📚 Documentation
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: