Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use existing dependency icon if available #2489

Merged
merged 1 commit into from
Nov 1, 2023
Merged

use existing dependency icon if available #2489

merged 1 commit into from
Nov 1, 2023

Conversation

dr-bonez
Copy link
Member

@dr-bonez dr-bonez commented Nov 1, 2023

No description provided.

@Blu-J
Copy link
Contributor

Blu-J commented Nov 1, 2023 •
edited
Loading

Proof that it works

Updated the code.
Installed the filebrowser via the marketplace.
Updated the code with the fix.
sideloaded the embassy pages.
Set up the config to use the filebrowser.
Then the proof shows that the image is now in the dependencies on this page.

image

@dr-bonez dr-bonez merged commit c14ca1d into master Nov 1, 2023
2 checks passed
@dr-bonez dr-bonez deleted the bugfix/existing-dep-icon branch November 9, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blu-J Blu-J Blu-J approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-bonez @Blu-J