Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetCDNAuthToken after Steam change #1447

Closed
wants to merge 4 commits into from

Conversation

oureveryday
Copy link
Contributor

@oureveryday oureveryday commented Oct 12, 2024

Move the GetCDNAuthToken from SteamApps to SteamContent

Rename CDNAuthTokenCallback to CDNAuthToken.
Remove the old get token method.
@xPaw
Copy link
Member

xPaw commented Oct 12, 2024

Result code still needs to be checked/available

@oureveryday
Copy link
Contributor Author

I didn't see result code in CContentServerDirectory_GetCDNAuthToken_Response

@xPaw
Copy link
Member

xPaw commented Oct 12, 2024

Service response itself should have a result. You should try testing it on invalid hostname / depotid, I would expect that to give a bad eresult.

@xPaw xPaw changed the title Fix getCDNAuthToken Fix GetCDNAuthToken after Steam change Oct 12, 2024
@xPaw xPaw added this to the 3.0.0 milestone Oct 12, 2024
@xPaw xPaw added the bug label Oct 12, 2024
@oureveryday
Copy link
Contributor Author

Service response itself should have a result. You should try testing it on invalid hostname / depotid, I would expect that to give a bad eresult.

If a invalid hostname / depotid passed, it will return null result.

@xPaw
Copy link
Member

xPaw commented Oct 12, 2024

it will return null result.

Yeah but what's the message.Result?

Also remove the callback emsg handler

Remove the old callback emsg handler
@oureveryday
Copy link
Contributor Author

Fixed that.

@xPaw
Copy link
Member

xPaw commented Oct 13, 2024

xmldoc in cdn client needs updating, see the failing build

@xPaw xPaw closed this in 453aa39 Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants