-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS incompatibilies related to system libraries #1501
Conversation
Added unit test and fixed another occurances of the same issue. Unit test was failing before, so it definitely proves that there was an issue. Thanks in advance for merging. |
By reverting the changes to the library paths and keeping the tests, I cannot get this to fail on my own MBP with macOS Sequoia 15.3 (24D60) with either .NET 8 or .NET 9 SDKs. 🤔 |
I'm not an expert in macOS so I don't know why you can't reproduce it locally, but it definitely did fail in CI:
(Those were the other two issues that I discovered accidentally after writing unit test for verification of the first one) |
Yeah, I saw that. I still have Questions. Will have a think about this - seems harmless atm but not sure what the wider impact is exactly. |
ah, got it. This only seems to affect .NET 9.0.1 / SDK 9.0.102 or higher. Iiiiiinteresting. |
If we have global.json for 8.0.100 latestMinor then why is dlopen on GitHub Actions looking in |
https://github.com/SteamRE/SteamKit/blob/master/SteamKit2/Tests/Tests.csproj#L5 sigh. ok I think I've wrapped up the loose ends here. and I'm not exactly happy with where we are but I think a hotfix makes sense. |
rollforward was specified in csprojs before global.json existed |
See Homebrew/homebrew-core#206331 (comment) for detailed reasoning and analysis.
If you could schedule a bugfix release with it (3.0.2), I'd appreciate that. Thanks in advance.
References: