Add tests for DepotChunk, validate PK zip magic #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xPaw
commented
Feb 6, 2025
xPaw
commented
- Add tests for depot chunks
- Validate PKzip header, throw for unknown compressions
xPaw
commented
Feb 6, 2025
| { | ||
| writtenDecompressed = VZipUtil.Decompress( buffer.AsSpan( 0, written ), destination, verifyChecksum: false ); | ||
| } | ||
| else if ( buffer[ 0 ] == 'P' && buffer[ 1 ] == 'K' && buffer[ 2 ] == 0x03 && buffer[ 3 ] == 0x04 ) // PKzip |
There was a problem hiding this comment.
Steam client code performs the same check.
xPaw
commented
Feb 6, 2025
|
|
||
| if ( buffer.Length > 1 && buffer[ 0 ] == 'V' && buffer[ 1 ] == 'Z' ) | ||
| if ( buffer.Length < 16 ) |
There was a problem hiding this comment.
Steam client checks for like 20 bytes for pkzip, and 22 bytes for vzip, I'm just being safe and checking for a smaller value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.