Documentation for what's new in Steeltoe v4 #337
+1,024
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview link: https://docs-steeltoe-pr-337.azurewebsites.net
|
bart-vmware
force-pushed
the
whatsnew-docs-v4
branch
3 times, most recently
from
0ab5de4 to
3adf1ce
Compare
bart-vmware
force-pushed
the
whatsnew-docs-v4
branch
from
3adf1ce to
e0e6f02
Compare
TimHess
reviewed
Jan 13, 2025
Co-authored-by: Tim Hess <[email protected]>
TimHess
requested changes
Jan 14, 2025
api/v4/welcome/whats-new.md
Outdated
|
|
||
| - Placeholder substitution changed internally (wrapping and taking ownership of sources), should be added as late as possible | ||
| - To improve performance, Config Server provider doesn't substitute placeholders by default anymore | ||
| - Call `AddPlaceholderResolver()` *before* `AddConfigServer()` to substitute placeholders from local appsettings.json |
There was a problem hiding this comment.
Suggested change
| - Call `AddPlaceholderResolver()` *before* `AddConfigServer()` to substitute placeholders from local appsettings.json | |
| - Call `AddPlaceholderResolver()` *before* `AddConfigServer()` to substitute placeholders before calling Config Server |
Calling it before is really only useful if there's a placeholder used for the Config Server client config, right?
There was a problem hiding this comment.
Yes, I suppose it could be something like (not actually existing properties):
{
"config-server-url": "http://${CONFIG_SERVER_HOSTNAME}:${CONFIG_SERVER_PORT}/path"
}where CONFIG_SERVER_HOSTNAME and CONFIG_SERVER_PORT are environment variables.
Co-authored-by: Tim Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents what's changed in the Steeltoe codebase, except for Management (will follow later).
Intentionally kept everything on a single page to enable search over all Steeltoe components.
Addresses the "welcome" part of #317.