Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: the type of GetEventsRequest.start_ledger has changed from str to int. #847

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Dec 16, 2023

No description provided.

The type of `GetEventsRequest.start_ledger` has changed from `str` to `int`.
@overcat
Copy link
Member Author

overcat commented Dec 16, 2023

#845

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Merging #847 (cdbb6d6) into main (a44fb38) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files         253      253           
  Lines       13239    13239           
=======================================
  Hits        13058    13058           
  Misses        181      181           
Flag Coverage Δ
unittests 98.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
stellar_sdk/soroban_rpc.py 100.00% <100.00%> (ø)
tests/test_soroban_server_async.py 100.00% <ø> (ø)
tests/test_soroban_server_sync.py 100.00% <ø> (ø)

@overcat overcat merged commit 7db69a4 into main Dec 16, 2023
46 checks passed
@overcat overcat deleted the fix/issue/559-2 branch December 16, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant