Automtaically add ipv6 entries to nix flake

[Pandapip1]

Solves #47 for NixOS

[welcome]

Thank you for submitting this pull request! We’ll get back to you as soon as we can!

[Pandapip1]

Just tested it on my NixOS system, this works.

[StevenBlack]

Thank you for this Gavin @Pandapip1.

Can someone please validate this?

Ping Dennis @Deleh or @toastal how does this PR appear to you?

[toastal]

The Nix code itself seems fine & good enough to me. I can’t really comment on if this is the best UX for users (like should there be a flag for if you want this support or not or is this universally an ‘improvement’ as my ISP doesn’t provide IPv6)

[Deleh]

I agree with @toastal. The code looks good and functionality is as expected, but it would make sense to keep the additional entries behind a mkEnableOption. E.g. blockAAAARequests or blockIPv6.

The outcome of networking.stevenBlackHosts.enable should reflect the hosts file as it is.

[Pandapip1]

Also went ahead and fixed your mkEnableOption usage.

Before:

nix-repl> (nixosModule { config = { networking.enableIPv6 = true; }; }).options.networking.stevenBlackHosts.blockSocial.description
"Whether to enable Additionally block social hosts.."

After:

nix-repl> (nixosModule { config = { networking.enableIPv6 = true; }; }).options.networking.stevenBlackHosts.blockSocial.description
"Whether to enable social hosts entries."

[Deleh]

A default value of config.networking.enableIPv6 seems fine for me. The changes were tested and work as expected 👍

Can you please extend the README accordingly?

[toastal]

I agree that it looks good

[StevenBlack]

Thank you for the assist Dennis @Deleh and @toastal. You folks are great!

Gavin @Pandapip1 this looks good to merge except for one subtle thing.

The root readme.md file is generative. There are actually 31 different "homepage" readme.md files in this repository, one for each distinct variant of hosts file. These are auto-generated from the file readme_template.md.

THEREFORE if you could please apply the readme changes to the file readme_template.md then this'll be good to merge.

[StevenBlack]

Thanks Gavin @Pandapip1! Merging.

[welcome]

Congratulations on merging your first pull request here! 🎉🎉🎉 You are now in our list of contributors. Welcome!