Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled POSITIONS_BY_ITEM #3

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

mms0316
Copy link
Contributor

@mms0316 mms0316 commented Apr 1, 2021

Needs work:

  • Swapping between hotbar and inventory
  • Dropping item with mouse
  • Placing item in Crafting inventory and then closing inventory
  • Changing items on the same inventory:
    • Splitting stack in half (right-click and dropping cursor on air slot in inventory)
    • Merging stacks (dropping cursor with item on non full item stack of same type)
    • Swapping stacks (dropping cursor with item on different item in inventory)
  • Receiving item (e.g. getting Holocoins from Banker and /givecoins)
  • Losing item (e.g. depositing Holocoins to Banker and /takecoins)
  • Dropping one item without losing entire stack (Q button)

Seems to be working:

  • Picking up item
  • Dropping whole stack item with Q button or ctrl+Q
  • Using shift key to switch inventories

mms0316 added 2 commits March 31, 2021 21:16
Needs work:
- Swapping between hotbar and inventory
- Dropping item with mouse
- Placing item in Crafting inventory and then closing inventory
- Changing items on the same inventory:
  - Splitting stack in half (right-click and dropping cursor on air slot in inventory)
  - Merging stacks (dropping cursor with item on non full item stack of same type)
  - Swapping stacks (dropping cursor with item on different item in inventory)
- Receiving item (e.g. getting Holocoins from Banker and /givecoins)
- Losing item (e.g. depositing Holocoins to Banker and /takecoins)
- Dropping one item without losing entire stack (Q button)

Seems to be working:
- Picking up item
- Dropping whole stack item with Q button or ctrl+Q
- Using shift key to switch inventories
- Created DIRTY_INVENTORY to be used to do a single full cache when inventory closes
- Removed caching items unrelated to ITEMEVENT_EXECUTORS
- Removed handling PlayerItemHeldEvent for now
- Fixed issues mentioned before, except with giving/taking items (not yet tested)
- Note: for some reason full caches are doing nothing on player login
@mms0316
Copy link
Contributor Author

mms0316 commented Apr 1, 2021

Fixed issues mentioned before, except with giving/taking items (not yet tested)

  • Created DIRTY_INVENTORY to be used to do a single full cache when inventory closes
  • Removed caching items unrelated to ITEMEVENT_EXECUTORS
  • Removed handling PlayerItemHeldEvent for now
  • Note: for some reason full caches are doing nothing on player login

- Was an oversight not to test hotkeys / mouse scroll
@mms0316
Copy link
Contributor Author

mms0316 commented Apr 1, 2021

Reenabled handling PlayerItemHeldEvent

  • It was an oversight not to test mouse scroll / number keys

@StrangeOne101 StrangeOne101 merged commit 0b351b2 into StrangeOne101:0.6 Apr 1, 2021
@mms0316 mms0316 deleted the 0.6-PositionsCache branch April 1, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants