Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds clubs models #86
Adds clubs models #86
Changes from 2 commits
8df6a95
21acb05
9066072
5334573
f75775b
27eb8c5
c943c02
2a9ab7f
e44c9a3
8ad5c37
ebda80f
ecddf05
7cc3cac
9c85301
9099f89
c27a346
8c713f4
72707ea
1fd05b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some pseudo-code (like what you would do, maybe in comments) would be nice here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I put there though? because I don't think we need anything in init() for Club Admins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe this doesn't need to be a data model (ie, it shouldn't be included in the
Models
collection). You can remove this function andextends Model
. Then it'll just be a view model -- something the UI can use to make specific actions easier, but doesn't need to provide the underlying data.