Remove custom Ref stringer (#1359)

I can't remember why we have this in the first place, but in case some new issue reminds us, we can deal with it then. Signed-off-by: Anders Eknert <[email protected]>
StyraInc · Jan 23, 2025 · 6880526 · 6880526
1 parent 2b25493
commit 6880526
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 112 deletions.
diff --git a/internal/ast/ref.go b/internal/ast/ref.go
diff --git a/internal/ast/ref_test.go b/internal/ast/ref_test.go
diff --git a/internal/lsp/completions/refs/defined.go b/internal/lsp/completions/refs/defined.go
@@ -22,7 +22,7 @@ func DefinedInModule(module *ast.Module, builtins map[string]*ast.Builtin) map[s
 
 	// first, create a reference for the package using the metadata
 	// if present
-	packagePrettyName := strings.TrimPrefix(rast.RefToString(module.Package.Path), "data.")
+	packagePrettyName := strings.TrimPrefix(module.Package.Path.String(), "data.")
 	packageDescription := defaultDescription(packagePrettyName)
 
 	packageAnnotation, ok := findAnnotationForPackage(module)
@@ -43,7 +43,7 @@ func DefinedInModule(module *ast.Module, builtins map[string]*ast.Builtin) map[s
 	ruleGroups := make(map[string][]*ast.Rule, len(module.Rules))
 
 	for _, rule := range module.Rules {
-		name := rast.RefToString(rule.Head.Ref())
+		name := rule.Head.Ref().String()
 
 		if strings.HasPrefix(name, "test_") {
 			continue

diff --git a/internal/lsp/documentsymbol.go b/internal/lsp/documentsymbol.go
@@ -41,7 +41,7 @@ func documentSymbols(
 	ruleGroups := make(map[string][]*ast.Rule, len(module.Rules))
 
 	for _, rule := range module.Rules {
-		name := rast.RefToString(rule.Head.Ref())
+		name := rule.Head.Ref().String()
 		ruleGroups[name] = append(ruleGroups[name], rule)
 	}
 
@@ -58,7 +58,7 @@ func documentSymbols(
 
 			ruleRange := locationToRange(rule.Location)
 			ruleSymbol := types.DocumentSymbol{
-				Name:           rast.RefToString(rule.Head.Ref()),
+				Name:           rule.Head.Ref().String(),
 				Kind:           kind,
 				Range:          ruleRange,
 				SelectionRange: ruleRange,
@@ -84,7 +84,7 @@ func documentSymbols(
 			}
 
 			groupSymbol := types.DocumentSymbol{
-				Name:           rast.RefToString(rules[0].Head.Ref()),
+				Name:           rules[0].Head.Ref().String(),
 				Kind:           kind,
 				Range:          groupRange,
 				SelectionRange: groupRange,