Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: better use of test helpers #1358

Merged
merged 1 commit into from
Jan 23, 2025
Merged

refactor: better use of test helpers #1358

merged 1 commit into from
Jan 23, 2025

Conversation

anderseknert
Copy link
Member

No description provided.

@anderseknert anderseknert force-pushed the test-improvements branch 2 times, most recently from daf34d3 to 41b5de6 Compare January 23, 2025 02:26
srenatus
srenatus approved these changes Jan 23, 2025
View reviewed changes
.lsp/.cache/db.transit.json Outdated Show resolved Hide resolved
charlieegan3
charlieegan3 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this all looks good to me, would be nice to lint for some of these if it's not too much work as I fear I might forget...

@anderseknert anderseknert merged commit 0d506bb into main Jan 23, 2025
5 checks passed
@anderseknert anderseknert deleted the test-improvements branch January 23, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlieegan3 charlieegan3 charlieegan3 approved these changes

@srenatus srenatus srenatus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anderseknert @srenatus @charlieegan3