Rule: inconsistent-args
#448
Conversation
anderseknert
force-pushed
the
inconsistent-args
branch
from
9d4f9c4 to
88d8e29
Compare
| # regal ignore:prefer-some-in-iteration | ||
| name := ast.ref_to_string(ast.functions[i].head.ref) | ||
| args_list := [args | | ||
| some j |
There was a problem hiding this comment.
Probably won't make a dent on performance, but we could add a i != j here, right?
| # regal ignore:prefer-some-in-iteration | ||
| args := ast.functions[j].head.args | ||
| ] | ||
| count(args_list) > 1 |
There was a problem hiding this comment.
Won't the arg list size always be > 1, as each rule is counted at least twice, once when iterating i and once for j?
There was a problem hiding this comment.
But the args_list only iterates on j.
|
|
||
| # regal ignore:prefer-some-in-iteration | ||
| name := ast.ref_to_string(ast.functions[i].head.ref) | ||
| args_list := [args | |
There was a problem hiding this comment.
We'd possibly get a perf boost by making args_list a set.
There was a problem hiding this comment.
If we didn't need to account for primitives, we could then simply just have made a count(args_list) > 1 check 😄 .
There was a problem hiding this comment.
We still need to iterate over it, so I don't think a set would perform better? 🤔
|
|
||
| # Return the _second_ function found by name, as that | ||
| # is reasonably the location the inconsistency is found | ||
| find_function_by_name(name) := [fn | |
There was a problem hiding this comment.
Unless we can a pinpoint the first function with an actual argument name inconsistency, isn't it more clear to just point to the first function declaration.
There was a problem hiding this comment.
Possibly, but the second function is at least arguably more likely to be inconsistent than the first :P
Warn on inconsistent argument names in repeated function declarations. Fixes #444 Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
inconsistent-args
branch
from
88d8e29 to
05a10f0
Compare
Warn on inconsistent argument names in repeated function declarations. Fixes StyraInc#444 Signed-off-by: Anders Eknert <[email protected]>
Warn on inconsistent argument names in repeated function declarations.
Fixes #444